Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
T
Tidal
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • PLN
  • Tidal
  • Repository

Switch branch/tag
  • Tidal
  • armada
  • tide-table
  • build_release_joins.py
Find file
BlameHistoryPermalink
  • PLN (Algolia)'s avatar
    fix(joins): the close clip was labelled "dry" while shipping a reverb tail · 57745a7c
    build_release_joins hardcoded its first closing clip as CLOSE · DRY, "what ships
    today". That was true exactly once — before any reverb was chosen. The clip is
    cut from the RENDERED last track, so the moment PLN picked a preset the file he
    auditioned had the echo baked in and the label said it did not.
    
    An audition UI that misdescribes what ships is the one bug this tool cannot
    have: its entire job is to let the ear check the actual artefact, and a wrong
    label turns a passed listen into a false clearance. Same family as the earlier
    allow-list that silently dropped reverb_preset — the output looked clean and was
    clean, of the wrong thing.
    
    Now the first entry is CLOSE · SHIPPED and reads the preset out of the release
    segments, so it renders as "SHIPPED · MORE tail baked in". Names the artefact
    from the data that produced it rather than from an assumption frozen at the time
    the code was written. Wrapped in try/except: a missing segments file drops the
    suffix rather than blocking the audition.
    
    The A/B variants are unchanged and still opt-in behind --close-ab.
    PLN (Algolia) authored Aug 16, 2026
    57745a7c
build_release_joins.py 10.1 KB
EditWeb IDE
×

Replace build_release_joins.py

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.